Skip to content

Board identification improvements #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2022
Merged

Board identification improvements #1674

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
72e9c64
Added test for os-specific config options
cmaglie Feb 23, 2022
c48573a
Build board config options structures only once and cache them
cmaglie Feb 22, 2022
db2a3d1
Board's build options properties are now calculated only once and cached
cmaglie Feb 23, 2022
c921d0c
Added tests for config options ordering
cmaglie Feb 23, 2022
baecc78
Renamed some variables to improve code readability
cmaglie Feb 23, 2022
14a424b
Added board config identification subroutines
cmaglie Feb 23, 2022
ccceb6c
Added board config detection in 'commands.identify' function
cmaglie Feb 24, 2022
1bcdd33
Updated docs
cmaglie Oct 14, 2022
d0ebfd7
Apply suggestions from code review
cmaglie Oct 17, 2022
024597e
Fixed comment
cmaglie Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added board config detection in 'commands.identify' function
  • Loading branch information
@cmaglie
cmaglie committed Oct 14, 2022
commit ccceb6c5ae38ed1585446dbe68425c6509cdcb78
9 changes: 8 additions & 1 deletion commands/board/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"time"

"github.com/arduino/arduino-cli/arduino"
"github.com/arduino/arduino-cli/arduino/cores"
"github.com/arduino/arduino-cli/arduino/cores/packagemanager"
"github.com/arduino/arduino-cli/arduino/discovery"
"github.com/arduino/arduino-cli/arduino/httpclient"
Expand Down Expand Up @@ -124,13 +125,19 @@ func identify(pme *packagemanager.Explorer, port *discovery.Port) ([]*rpc.BoardL
// first query installed cores through the Package Manager
logrus.Debug("Querying installed cores for board identification...")
for _, board := range pme.IdentifyBoard(port.Properties) {
fqbn, err := cores.ParseFQBN(board.FQBN())
if err != nil {
return nil, &arduino.InvalidFQBNError{Cause: err}
}
fqbn.Configs = board.IdentifyBoardConfiguration(port.Properties)

// We need the Platform maintaner for sorting so we set it here
platform := &rpc.Platform{
Maintainer: board.PlatformRelease.Platform.Package.Maintainer,
}
boards = append(boards, &rpc.BoardListItem{
Name: board.Name(),
Fqbn: board.FQBN(),
Fqbn: fqbn.String(),
Platform: platform,
})
}
Expand Down