Skip to content

[breaking] Remove auto detection of Arduino IDE built-in libraries and tools / Allow gRPC install of built-in libraries #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 2, 2022
Merged

[breaking] Remove auto detection of Arduino IDE built-in libraries and tools / Allow gRPC install of built-in libraries #1817

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fd5dc83
Removed IDE-bundle autodetection
cmaglie Jul 26, 2022
006f710
Do not return bundled tools folder with HardwarePaths
cmaglie Aug 1, 2022
deda8e7
Created configuration functions to obtain data dir and downloads dir
cmaglie Aug 25, 2022
49d4dba
Bundled libraries configuration is now considere a single directory
cmaglie Aug 25, 2022
a213270
Allow library installation on bundled libs dir via gRPC
cmaglie Aug 26, 2022
bc9c8cb
Added integration test for library install in bundled directory
cmaglie Aug 26, 2022
1bcfd73
Fixed nil pointer exception in build options extraction
cmaglie Aug 27, 2022
a4c87f4
Updated docs
cmaglie Jul 27, 2022
00f214a
Removed useless custom env bindings
cmaglie Aug 31, 2022
aaea3be
Applied code review changes
cmaglie Aug 31, 2022
3c19b77
Set builtin libraries dir by default when running as a daemon
cmaglie Aug 31, 2022
be777ad
Added test for regression
cmaglie Sep 1, 2022
ad98097
Fixed regression: 'lib uninstall' must operate only on user dir
cmaglie Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not return bundled tools folder with HardwarePaths
  • Loading branch information
@cmaglie
cmaglie committed Sep 1, 2022
commit 006f7109a8e145030d767f00ef1959f43766ec6a
4 changes: 0 additions & 4 deletions configuration/directories.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ import (
func HardwareDirectories(settings *viper.Viper) paths.PathList {
res := paths.PathList{}

for _, bundledHardwareDir := range BuiltinToolsDirectories(Settings) {
res.Add(bundledHardwareDir)
}

if settings.IsSet("directories.Data") {
packagesDir := PackagesDir(Settings)
if packagesDir.IsDir() {
Expand Down