Skip to content

Check if a signed URL is specified and use it download tools #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Check if a signed URL is specified and use it download tools #953

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a87ca2
Wrap v2 tools install function inside tools.Download
MatteoPologruto May 15, 2024
ed8eac6
Download tools defaulting to the replace behaviour
MatteoPologruto May 22, 2024
887b22b
Improve archive renamer and fix failing tests
MatteoPologruto May 29, 2024
a882ed7
Find the correct tool and system when `version=latest` is specified
MatteoPologruto May 29, 2024
18e9250
Reintroduce caching option when downloading tools
MatteoPologruto Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve archive renamer and fix failing tests
  • Loading branch information
@MatteoPologruto
MatteoPologruto committed Jun 19, 2024
commit 887b22bbf9804958b3752002e51f20548892766a
7 changes: 5 additions & 2 deletions v2/pkgs/tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,11 @@ func (t *Tools) Remove(ctx context.Context, payload *tools.ToolPayload) (*tools.
func rename(base string) extract.Renamer {
return func(path string) string {
parts := strings.Split(filepath.ToSlash(path), "/")
path = strings.Join(parts[1:], "/")
path = filepath.Join(base, path)
newPath := strings.Join(parts[1:], "/")
if newPath == "" {
newPath = filepath.Join(newPath, path)
}
path = filepath.Join(base, newPath)
return path
}
}
Expand Down