Add Nano RP2040 Connect to sketch compilation CI workflow #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd combo Pin A5 is used by the "StringComparisonOperators" example. The Nano RP2040 Connect uses the u-blox NINA-W102's ADC for pins A4-A7. This means those pins are only usable in a sketch when it contains an `#include` directive for the WiFiNINA library. This results in compilation of that example failing for the Nano RP 2040 Connect. The need for this `#include` directive is surely an intentional design decision, and thus not likely to change. Although it is possible to add compatibility to the sketch with a preprocessor conditional, the added complexity in what is intended to be a very beginner friendly example is likely not worth it. Another option would be to change the sketch to use a different pin, but that sort of change does not fall within my remit. The error message the user will experience if they attempt to compile this sketch for their board is reasonably good so I suppose the realistic best way forward is to consider this not a bug and just skip the sketch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.