Skip to content

Increase sketchbook list item height #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

Increase sketchbook list item height #1146

merged 1 commit into from
Jul 5, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

Sketchbook list item height must be 30px.

Change description

Added a CSS rule to set the height to 30px.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@francescospissu francescospissu linked an issue Jul 5, 2022 that may be closed by this pull request
"Sketchbook" view listed item vertical spacing too small #1147
Closed
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 5, 2022
AlbyIanna
AlbyIanna approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francescospissu francescospissu merged commit 06acd7f into main Jul 5, 2022
@francescospissu francescospissu deleted the fspissu/list-item-size branch July 5, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

@91volt 91volt Awaiting requested review from 91volt

1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Sketchbook" view listed item vertical spacing too small
3 participants
@francescospissu @AlbyIanna @per1234