Skip to content

Fix errors in package index project data unit tests for discoveryDependencies #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Fix errors in package index project data unit tests for discoveryDependencies #292

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26e2198
Add missing test table handling code for discovery dependencies
per1234 Nov 11, 2021
c547ee4
Fix errors in package index project data test assertions
per1234 Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add missing test table handling code for discovery dependencies 
Assertions were added to the unit test tables for package index project data generation of pluggable discovery
dependencies. However, the test table handling code was not updated to use those assertions, so they were ignored.
  • Loading branch information
@per1234
per1234 committed Nov 11, 2021
commit 26e2198ee0c3e747db08543c1c2f45d2f506f966
8 changes: 8 additions & 0 deletions internal/project/projectdata/packageindex_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,14 @@ func TestInitializeForPackageIndex(t *testing.T) {
}
}

testTable.packageIndexDiscoveryDependenciesAssertion(t, PackageIndexDiscoveryDependencies(), testTable.testName)
if PackageIndexDiscoveryDependencies() != nil {
for index, packageIndexDiscoveryDependency := range PackageIndexDiscoveryDependencies() {
assert.Equal(t, testTable.packageIndexDiscoveryDependenciesDataAssertion[index].ID, packageIndexDiscoveryDependency.ID, testTable.testName)
assert.Equal(t, testTable.packageIndexDiscoveryDependenciesDataAssertion[index].JSONPointer, packageIndexDiscoveryDependency.JSONPointer, testTable.testName)
}
}

testTable.packageIndexToolsAssertion(t, PackageIndexTools(), testTable.testName)
if PackageIndexTools() != nil {
for index, packageIndexTool := range PackageIndexTools() {
Expand Down