Generate GetBucketReplication, PutBucketReplication, GetBucketPolicy, GetBucketLocation, GetBucketMetadataTableConfiguration, GetBucketOwnershipControls

[peterrsongg]

Description

Generates 6 more operations. I had to add some logic for deprecation messages and response payload members where the response payload member could've been renamed, which only happens in s3. I've added a new customization called emitDifferentPrivateDataType that allows the private data type to differ from the public property data type. This happens in GetBucketLocationResponse where the Location property is of S3Region type, but the private member is a string. Since we agreed to generate everything the same I added this customization.

For PutBucketReplication I uncommented the relevant integ test and ran it. This required me to update the test to initialize the List<ReplicationRule> and also add some additional arguments. Just as a sanity check I made sure that in main we also have to do this so I'm sure this isn't a breaking change.

I've checked all the missingMethod assembly comparison output and the method is there. I believe it's because it changed from public to internal.

Motivation and Context

Testing

DRY_RUN SUCCESSFUL e3da56db-24ac-4368-b043-487a0d004b2a

AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.ReplicationRule/MethodAdded: New method System.String get_Prefix() in Amazon.S3.Model.ReplicationRule
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.ReplicationRule/MethodRemoved: Missing method System.Void set_Priority(System.Int32) in Amazon.S3.Model.ReplicationRule
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.ReplicationRule/MethodAdded: New method System.Void set_Priority(System.Nullable<System.Int32>) in Amazon.S3.Model.ReplicationRule
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.ReplicationRule/MethodAdded: New method System.Void set_Prefix(System.String) in Amazon.S3.Model.ReplicationRule
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.ReplicationRule/MethodRemoved: Missing method System.Int32 get_Priority() in Amazon.S3.Model.ReplicationRule
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.ReplicationRule/MethodAdded: New method System.Nullable<System.Int32> get_Priority() in Amazon.S3.Model.ReplicationRule
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.ReplicationDestination/MethodRemoved: Missing method System.Boolean IsSetAccountId() in Amazon.S3.Model.ReplicationDestination
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.ReplicationDestination/MethodRemoved: Missing method System.Boolean IsSetEncryptionConfiguration() in Amazon.S3.Model.ReplicationDestination
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.ReplicationDestination/MethodRemoved: Missing method System.Boolean IsSetAccessControlTranslation() in Amazon.S3.Model.ReplicationDestination
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.PutBucketReplicationRequest/MethodAdded: New method System.String get_ContentMD5() in Amazon.S3.Model.PutBucketReplicationRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.PutBucketReplicationRequest/MethodAdded: New method System.Void set_ContentMD5(System.String) in Amazon.S3.Model.PutBucketReplicationRequest

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license