-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Update deploy-an-angular-site.mdx #17946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hotfix for Update Build Settings For angular. Fixed and working. Request to change PagesBuildPreset to this solution or add instructions to change the ng build command in package.json. Request to update the Angular preset on the dashboard to match. Seems like there are quite a few people with this issue. See: cloudflare/workers-sdk#5527 Also: https://stackoverflow.com/questions/78463333/fail-to-deploy-angular-project-on-cloudflare-pages/79151848#79151848 And: https://community.cloudflare.com/t/angular-app-deployed-to-pages-is-unavailable-on-domain/632745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 2 total issue(s) found.
src/content/docs/pages/framework-guides/deploy-an-angular-site.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pages/framework-guides/deploy-an-angular-site.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pages/framework-guides/deploy-an-angular-site.mdx
Outdated
Show resolved
Hide resolved
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated build settings for the Angular deployment tutorial to address common build failures.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add What is Hyperlint?Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation. |
Hi @dario-piotrowicz @GregBrimble - Would you mind confirming this for accuracy? Thank you! |
Congratulations @fahrnbach, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmakukufq09420djve8xgu6j3 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Thank you for the contribution @fahrnbach ! |
* Update deploy-an-angular-site.mdx Hotfix for Update Build Settings For angular. Fixed and working. Request to change PagesBuildPreset to this solution or add instructions to change the ng build command in package.json. Request to update the Angular preset on the dashboard to match. Seems like there are quite a few people with this issue. See: cloudflare/workers-sdk#5527 Also: https://stackoverflow.com/questions/78463333/fail-to-deploy-angular-project-on-cloudflare-pages/79151848#79151848 And: https://community.cloudflare.com/t/angular-app-deployed-to-pages-is-unavailable-on-domain/632745 * Update formatting for warning message * Updated formatting for warning message * Updated warning message formatting from my unlogged in account * Update src/content/docs/pages/framework-guides/deploy-an-angular-site.mdx --------- Co-authored-by: Jacob <[email protected]> Co-authored-by: ToriLindsay <[email protected]>
Happy to help! If y'all are ever looking for some full time help, I'm available for hire. Thanks :) |
Hotfix to Update Build Settings for Angular Deployment Tutorial. Fixed and working.
https://developers.cloudflare.com/pages/framework-guides/deploy-an-angular-site/
Following thie default project settings result in failed build.
Request to change PagesBuildPreset to this working solution or add instructions to
change the ng build command in package.json.
Request to update the Angular preset on the dashboard to match.
Seems like there are quite a few people with this issue.
See: cloudflare/workers-sdk#5527
Also: https://stackoverflow.com/questions/78463333/fail-to-deploy-angular-project-on-cloudflare-pages/79151848#79151848
And: https://community.cloudflare.com/t/angular-app-deployed-to-pages-is-unavailable-on-domain/632745