Skip to content

[CF1] custom block dialogs rbi #22208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Conversation

deadlypants1973
Copy link
Contributor

Summary

PCX-16380

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@deadlypants1973 deadlypants1973 requested review from maxvp, ranbel and a team as code owners May 5, 2025 13:52
@github-actions github-actions bot added the size/s label May 5, 2025
Copy link
Contributor

hyperlint-ai bot commented May 5, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Introduced custom block dialogs feature for enhanced user guidance during blocked actions in Browser Isolation.

  • Added a new section on custom block dialogs in the isolation policies documentation.
  • Outlined the configuration options for custom block dialogs, including query parameters.
  • Noted that custom block dialogs are currently in beta.

Modified Files

  • src/content/docs/cloudflare-one/policies/browser-isolation/isolation-policies.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Copy link
Contributor

@cdisher cdisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadlypants1973 deadlypants1973 merged commit 94b3cdc into production May 12, 2025
12 checks passed
@deadlypants1973 deadlypants1973 deleted the kate/fixes-customblock branch May 12, 2025 17:16
daisyfaithauma pushed a commit that referenced this pull request May 13, 2025
* [CF1] custom block dialogs rbi

* Apply suggestions from code review

PCX

Co-authored-by: Maddy <[email protected]>

---------

Co-authored-by: Maddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants