Skip to content

impl: support for Toolbox 2.6.3 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 10, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: resolve agent only after workspace was resolved
Switched the order of the steps, the agent and hist state is resolved
only after the workspace was resolved and after it was in a running
state. Otherwise URI handling during workspace startup could provide
misleading errors related to agent not existing or not being ready.
  • Loading branch information
fioan89 committed May 29, 2025
commit 4044e0dde456ff50afc00adc17e7fbd5a14a4508
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,11 @@ open class CoderProtocolHandler(
val workspaceName = resolveWorkspaceName(params) ?: return
val restClient = buildRestClient(deploymentURL, token) ?: return
val workspace = restClient.workspaces().matchName(workspaceName, deploymentURL) ?: return
val agent = resolveAgent(params, workspace) ?: return

if (!prepareWorkspace(workspace, restClient, workspaceName, deploymentURL)) return

// we resolve the agent after the workspace is started otherwise we can get misleading
// errors like: no agent available while workspace is starting or stopping
val agent = resolveAgent(params, workspace) ?: return
if (!ensureAgentIsReady(workspace, agent)) return

val cli = configureCli(deploymentURL, restClient)
Expand Down
Loading