Skip to content

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Dec 3, 2020

Part of #27529.

Summary of Changes

  • ObjectResultExecutor constructor that provide a null MVCOptions was removed since that will eventually trigger a null-ref in the code.
  • Remove GetFileStream API in PhysicalFileResultExecutor and VirtualFileResultExecutor because codepath is no-longer invoked.
  • Remove AllowShortCircuitingValidationWhenNoValidatorsArePresent in ValidationVisitor because value no-ops and has been obsolete since 3.0.
  • Remove RazorViewAttribute and RazorPageAttribute and instances of use since they are deprecated in favor of newer APIs.
  • Remove unnecessary constructor for ViewComponentResultExecutor which set a null WriterFactory since the value was overridden anyways.
  • Obsolete CompatabilityVersion type.

@captainsafia captainsafia added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Dec 3, 2020
@captainsafia captainsafia added the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@captainsafia captainsafia requested review from SteveSandersonMS and a team as code owners December 9, 2020 01:16
@pranavkm pranavkm added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews labels Dec 14, 2020
@captainsafia
Copy link
Member Author

@dotnet/aspnet-api-review This is good for review. I've removed references to SetCompatibilityVersion per our discussion.

@ghost
Copy link

ghost commented Dec 25, 2020

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@pranavkm pranavkm added this to the 6.0-preview1 milestone Dec 25, 2020
@ghost ghost merged commit 7a2f5cc into master Dec 25, 2020
@ghost ghost deleted the obsoletion/mvc branch December 25, 2020 06:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-approved API was approved in API review, it can be implemented area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants