-
Notifications
You must be signed in to change notification settings - Fork 7.7k
feat(variant): add kode dot ESP32-S3 board with QSPI LCD, SD and GPIO … #11371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
20b157a
feat(variant): add KodeDot ESP32-S3 board with QSPI LCD, SD and GPIO …
LusimiCollado fc176ed
fix(kodedot): Reorder board definitions and translate comments to Eng…
LusimiCollado 8894a63
fix(kodedot): Clean up OTA override and remove unused partition menu …
LusimiCollado df77dad
fix(kodedot): Build board changed from ESP32S3_DEV to KODE_DOT on kod…
LusimiCollado 687a1b6
Merge branch 'master' into master
LusimiCollado f3bac28
Merge branch 'master' into master
LusimiCollado fa56eee
ci(pre-commit): Fix whitespace, EOLs and codespell 'Analog'
LusimiCollado 54785c5
Merge branch 'espressif:master' into master
LusimiCollado 000a2d8
Merge branch 'espressif:master' into master
LusimiCollado b07d38e
ci(pre-commit): Add bash script formatter
LusimiCollado 1555225
fix(merge): New name and description for custom merge tool and change…
LusimiCollado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ci(pre-commit): Fix whitespace, EOLs and codespell 'Analog'
- Loading branch information
commit fa56eee815a683d15d465f51a7496613783390b0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,14 @@ | ||
extern "C" bool verifyRollbackLater() { | ||
// Returning true prevents the OTA image from being marked as valid | ||
// until you explicitly confirm it after the first boot. | ||
return true; | ||
} | ||
// custom_ota_override.cpp | ||
// This function overrides the weak definition of `verifyRollbackLater()` in the kode dot board. | ||
|
||
extern "C" { | ||
// Declare the weak function symbol to override it | ||
bool verifyRollbackLater() __attribute__((weak)); | ||
} | ||
|
||
// Custom implementation of verifyRollbackLater() | ||
// Returning `true` prevents the OTA image from being automatically marked as valid. | ||
// This ensures that the system will roll back to the previous image unless it is explicitly validated later. | ||
bool verifyRollbackLater() { | ||
LusimiCollado marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return true; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.