feat(ai): Schema title, maximum, minimum, and propertyOrdering
#9047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16742c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (84,761 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
hsubox76
reviewed
May 16, 2025
packages/ai/src/types/schema.ts
Outdated
| /** Optional. The items of the property. */ | ||
| items?: T; | ||
| /** Optional. Map of `Schema` objects. */ | ||
| properties?: { | ||
| [k: string]: T; | ||
| }; | ||
| /** | ||
| * A hint to the gemini model, suggesting the order in which the keys should appear in the |
There was a problem hiding this comment.
Gemini capitalized. Actually is this only for Gemini models?
There was a problem hiding this comment.
I think it's only for Gemini models, but just in case i'll reword this to simply 'A hint suggesting the order in which the keys should appear in the generated JSON string.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new properties to
SchemaShared;title,maximum,minimum, andpropertyOrdering. I added these properties to the unit tests.The unit tests in
schema-builder.test.tswere refactored to perform smaller property comparisons instead of direct large object comparisons. I found that this makes tests easier to read, and less brittle to failures from small unrelated changes to the large test objects.