Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3247
Fixes #3239
The
fast-crc32c
native module required by the storage emulator has been causing problems with our Firepit builds as well as running the NPM module on ARM systems.I searched for a suitable all-JS replacement but was not able to find one which seemed to be high quality. So instead I used Wikipedia and Stackoverflow to figure out how to implement the algorithm ourselves and remove the dependency entirely.
Scenarios Tested
I lifted 100% of the test cases from the
fast-crc32c
library we previously depended on and ran them against this new implementation, they all pass.I also did an e2e test with this simple Cloud function:
It works fine, but if I intentionally botch the
crc
implementation then we get this error:Sample Commands
N/A