Include appId in WebConfig

[samtstern]

Description

Fixes #2798

Scenarios Tested

Fetch __init.js with a site<>webapp linked:

$ http http://localhost:5090/__/firebase/init.js?useEmulator=true
HTTP/1.1 200 OK
Connection: keep-alive
Content-Length: 1900
Content-Type: application/javascript
Date: Thu, 08 Apr 2021 13:28:40 GMT
Keep-Alive: timeout=5

if (typeof firebase === 'undefined') throw new Error('hosting/init-error: Firebase SDK not detected. You must include it before /__/firebase/init.js');
var firebaseConfig = {
  "projectId": "fir-dumpster",
  "appId": "1:733471010301:web:1d80ddc9385abaa7d7fd94",
  "databaseURL": "https://fir-dumpster.firebaseio.com",
  "storageBucket": "fir-dumpster.appspot.com",
  "locationId": "us-central",
  "apiKey": "AIzaSyD3Vh8KNo27y8uF6z3hCPx7vJ20i_KjBPk",
  "authDomain": "fir-dumpster.firebaseapp.com",
  "messagingSenderId": "733471010301"
};
if (firebaseConfig) {
  firebase.initializeApp(firebaseConfig);

  var firebaseEmulators = {};
  if (firebaseEmulators) {
    console.log("Automatically connecting Firebase SDKs to running emulators:");
    Object.keys(firebaseEmulators).forEach(function(key) {
      console.log('\t' + key + ': http://' +  firebaseEmulators[key].host + ':' + firebaseEmulators[key].port );
    });

    if (firebaseEmulators.database && typeof firebase.database === 'function') {
      firebase.database().useEmulator(firebaseEmulators.database.host, firebaseEmulators.database.port);
    }

    if (firebaseEmulators.firestore && typeof firebase.firestore === 'function') {
      firebase.firestore().useEmulator(firebaseEmulators.firestore.host, firebaseEmulators.firestore.port);
    }

    if (firebaseEmulators.functions && typeof firebase.functions === 'function') {
      firebase.functions().useEmulator(firebaseEmulators.functions.host, firebaseEmulators.functions.port);
    }

    if (firebaseEmulators.auth && typeof firebase.auth === 'function') {
      firebase.auth().useEmulator('http://' + firebaseEmulators.auth.host + ':' + firebaseEmulators.auth.port);
    }
  } else {
    console.log("To automatically connect the Firebase SDKs to running emulators, replace '/__/firebase/init.js' with '/__/firebase/init.js?useEmulator=true' in your index.html");
  }
}

Fetch __init.js with a totally bogus project ID:

$ http http://localhost:5090/__/firebase/init.js?useEmulator=true
HTTP/1.1 200 OK
Connection: keep-alive
Content-Length: 1545
Content-Type: application/javascript
Date: Thu, 08 Apr 2021 13:30:51 GMT
Keep-Alive: timeout=5

if (typeof firebase === 'undefined') throw new Error('hosting/init-error: Firebase SDK not detected. You must include it before /__/firebase/init.js');
var firebaseConfig = undefined;
if (firebaseConfig) {
  firebase.initializeApp(firebaseConfig);

  var firebaseEmulators = {};
  if (firebaseEmulators) {
    console.log("Automatically connecting Firebase SDKs to running emulators:");
    Object.keys(firebaseEmulators).forEach(function(key) {
      console.log('\t' + key + ': http://' +  firebaseEmulators[key].host + ':' + firebaseEmulators[key].port );
    });

    if (firebaseEmulators.database && typeof firebase.database === 'function') {
      firebase.database().useEmulator(firebaseEmulators.database.host, firebaseEmulators.database.port);
    }

    if (firebaseEmulators.firestore && typeof firebase.firestore === 'function') {
      firebase.firestore().useEmulator(firebaseEmulators.firestore.host, firebaseEmulators.firestore.port);
    }

    if (firebaseEmulators.functions && typeof firebase.functions === 'function') {
      firebase.functions().useEmulator(firebaseEmulators.functions.host, firebaseEmulators.functions.port);
    }

    if (firebaseEmulators.auth && typeof firebase.auth === 'function') {
      firebase.auth().useEmulator('http://' + firebaseEmulators.auth.host + ':' + firebaseEmulators.auth.port);
    }
  } else {
    console.log("To automatically connect the Firebase SDKs to running emulators, replace '/__/firebase/init.js' with '/__/firebase/init.js?useEmulator=true' in your index.html");
  }
}

Sample Commands

[samtstern]

Bump @kmcnellis can you take a quick look at this one?

[kmcnellis]

Does the emulator support non-default sites?

[samtstern]

At the moment, no. One day!

[kmcnellis]

Probably worth a try/catch around this

[samtstern]

The only caller has a try/catch that does the right thing. I'm gonna leave it rather than increase the scope of this refactor.

[kmcnellis]

If it's a bogus project ID, should we make a bogus config object as well? Or does firebaseConfig = undefined allow everything to still work in the emulator? I don't think it should be a hard requirement to use a real project id with the emulators

[samtstern]

@kmcnellis we're working on some emulator-suite-wide handling for bogus project IDs but right now this maintains the status quo: the emulator will start in a somewhat degraded mode with a bogus project ID.