Skip to content

feat(firebase_messaging): Adds the action identifier #17324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hackmodford
Copy link

@Hackmodford Hackmodford commented May 1, 2025

Description

Adds the action identifier to the RemoteMessage object

Related Issues

#17315

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

google-cla bot commented May 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Hackmodford Hackmodford changed the title Adds the action identifier feat(firebase_messaging): Adds the action identifier May 1, 2025
@MichaelVerdon
Copy link
Contributor

Hey there 👋 , can you please sign the CLA?

@russellwheatley
Copy link
Member

@Hackmodford - Considering this is Apple specific, I think it should be on this: https://github.com/Hackmodford/flutterfire/blob/feat(firebase_messaging)--Add-ios-action-identifier/packages/firebase_messaging/firebase_messaging_platform_interface/lib/src/remote_notification.dart#L69

You can update it on the notificationDict by accessing notificationDict["@notification"]["@apple"]. You will also need to sign the CLA.

@russellwheatley russellwheatley added blocked: customer-response Waiting for customer response, e.g. more information was requested. plugin: messaging platform: ios Issues / PRs which are specifically for iOS. labels May 13, 2025
@Hackmodford
Copy link
Author

Hackmodford commented May 14, 2025

@russellwheatley I considered that, but noticed the category (which is Apple specific) is not there. So I put it next to that for consistency.

@MichaelVerdon I'm in the process of getting authorization from my company to sign the CLA.

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels May 14, 2025
@Hackmodford
Copy link
Author

CLA has been signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention This issue needs maintainer attention. platform: ios Issues / PRs which are specifically for iOS. plugin: messaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants