Update Codable snippet to use explicit typing #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Friese <[email protected]>
morganchen12
approved these changes
Mar 1, 2022
|
The Firestore version in these snippets is pretty heavily outdated, so you'll need to update it before CI passes. |
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
morganchen12
approved these changes
Mar 1, 2022
| ABBBF144CC83E8593B7A84A1 /* Pods-firestore-smoketestTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-firestore-smoketestTests.release.xcconfig"; path = "Target Support Files/Pods-firestore-smoketestTests/Pods-firestore-smoketestTests.release.xcconfig"; sourceTree = "<group>"; }; | ||
| E359A43AF922FF866A944E0E /* Pods-firestore-smoketestTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-firestore-smoketestTests.debug.xcconfig"; path = "Target Support Files/Pods-firestore-smoketestTests/Pods-firestore-smoketestTests.debug.xcconfig"; sourceTree = "<group>"; }; | ||
| F60D5136BFF2B9F03E718D26 /* Pods_firestore_smoketestUITests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_firestore_smoketestUITests.framework; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| F921D2527DC19B931C2783FB /* Pods-firestore-smoketestUITests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-firestore-smoketestUITests.release.xcconfig"; path = "Target Support Files/Pods-firestore-smoketestUITests/Pods-firestore-smoketestUITests.release.xcconfig"; sourceTree = "<group>"; }; |
There was a problem hiding this comment.
nit: run pod deintegrate to remove this diff.
Signed-off-by: Peter Friese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the snippet for using Codable to fetch data to use explicit typing introduced in firebase/firebase-ios-sdk#9101
Signed-off-by: Peter Friese [email protected]