Skip to content

Bump bytestring to >= 0.10 for correct IsString ByteString instance #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Bump bytestring to >= 0.10 for correct IsString ByteString instance #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions resolv.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ tested-with:
-- GHC == 7.10.3
-- GHC == 7.8.4
-- GHC == 7.6.3
Copy link

@emilypi emilypi Aug 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tho, to follow up, the stats show <2% of users are on GHCs <8.4 as of the last Yearly Haskell Survey in 2021, which is a further diminishing category as time goes on (esp. with respect to the 7.x series). Considering that the lower bound cap for base places you outside of the large number of performance improvements seen in bytestring-0.11, I'm not sure that keeping these old GHC versions is the prudent choice. The rest of the ecosystem, as well as most of the core libraries, now require a GHC of at least 8.x. What do you think about dropping the older GHCs to bring the library in line with what you can reasonably test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear your message.
I am happy to drop any GHC 7.x if it brings trouble. E.g., should resolv get new functionality which needs testing or wants to use newer GHC features, there would be no reason to hang on to ancient GHCs. But I'd drop these if there is need; otherwise, while resolv is stable, I see no harm in keeping them around.

-- GHC == 7.4.2

source-repository head
type: git
Expand All @@ -95,11 +94,14 @@ library
Compat

-- we need binary-0.7.3 for isolate
build-depends: base >= 4.5 && < 4.18
, base16-bytestring >= 0.1 && < 1.1
, binary ^>= 0.7.3 || ^>= 0.8
, bytestring >= 0.9.2 && < 0.12
, containers ^>= 0.4.2.1 || ^>= 0.5 || ^>= 0.6
build-depends: base >= 4.6 && < 4.18
-- bytestring-0.10.0.0 was shipped with GHC 7.6 (base-4.6)
, base16-bytestring >= 0.1 && < 1.1
, binary ^>= 0.7.3 || ^>= 0.8
, bytestring >= 0.10.0.0 && < 0.12
-- instance IsString ByteString exists in its form since bytestring-0.10.0.0
-- see https://github.com/haskell-hvr/resolv/pull/13#issuecomment-1213876161
, containers ^>= 0.4.2.1 || ^>= 0.5 || ^>= 0.6

ghc-options: -Wall
include-dirs: cbits
Expand Down