Skip to content

Suggestion #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Suggestion #3278

merged 2 commits into from
Jan 24, 2023

Conversation

bogdanbacosca
Copy link
Contributor

@bogdanbacosca bogdanbacosca commented Nov 26, 2022

Will this make the idea more clear or the text more readable?

Replacing:
Numeric conversion happens in mathematical functions and expressions automatically.
With:
Numeric conversion in mathematical functions and expressions happen automatically.

Will this make the idea more clear or the text more readable?
@@ -34,7 +34,7 @@ String conversion is mostly obvious. A `false` becomes `"false"`, `null` becomes

## Numeric Conversion

Numeric conversion happens in mathematical functions and expressions automatically.
Numeric conversion in mathematical functions and expressions happen automatically.
Copy link
Member

@joaquinelio joaquinelio Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Numeric conversion in mathematical functions and expressions happen automatically.
Numeric conversion happens automatically in mathematical functions and expressions.

warning I am not a native eng speaker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquinelio your version looks good too

@@ -34,7 +34,7 @@ String conversion is mostly obvious. A `false` becomes `"false"`, `null` becomes

## Numeric Conversion

Numeric conversion happens in mathematical functions and expressions automatically.
Numeric conversion in mathematical functions and expressions happen automatically.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, (I like it more but I'm not sure if I can start a sentence this way)

Suggested change
Numeric conversion in mathematical functions and expressions happen automatically.
In mathematical functions and expressions, the numeric conversion happens automatically.

@GopalanHarish
Copy link

As a non-native English speaker, the original text "Numeric conversion happens in mathematical functions and expressions automatically." is easier to understand.

@joaquinelio
Copy link
Member

The original sounds weird to me (non-native too)

I liked that the suggestion put the words "happens automatically" together

It would be easier to read with commas.
Numeric conversion, in mathematical functions and expressions, happens automatically.

My suggestion
In mathematical functions and expressions, the numeric conversion happens automatically.

@iliakan
Copy link
Member

iliakan commented Nov 26, 2022

Numeric conversion in mathematical functions and expressions happens automatically|? ;)

@joaquinelio
Copy link
Member

It seems ok...
for this non-native at least :)

@bogdanbacosca
Copy link
Contributor Author

@iliakan I have updated the PR with your suggestion.

@iliakan iliakan merged commit 03b8f2e into javascript-tutorial:master Jan 24, 2023
@bogdanbacosca bogdanbacosca deleted the work branch January 31, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants