-
Notifications
You must be signed in to change notification settings - Fork 4k
Suggestion #3278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion #3278
Conversation
Will this make the idea more clear or the text more readable?
@@ -34,7 +34,7 @@ String conversion is mostly obvious. A `false` becomes `"false"`, `null` becomes | |||
|
|||
## Numeric Conversion | |||
|
|||
Numeric conversion happens in mathematical functions and expressions automatically. | |||
Numeric conversion in mathematical functions and expressions happen automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numeric conversion in mathematical functions and expressions happen automatically. | |
Numeric conversion happens automatically in mathematical functions and expressions. |
warning I am not a native eng speaker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaquinelio your version looks good too
@@ -34,7 +34,7 @@ String conversion is mostly obvious. A `false` becomes `"false"`, `null` becomes | |||
|
|||
## Numeric Conversion | |||
|
|||
Numeric conversion happens in mathematical functions and expressions automatically. | |||
Numeric conversion in mathematical functions and expressions happen automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, (I like it more but I'm not sure if I can start a sentence this way)
Numeric conversion in mathematical functions and expressions happen automatically. | |
In mathematical functions and expressions, the numeric conversion happens automatically. |
As a non-native English speaker, the original text "Numeric conversion happens in mathematical functions and expressions automatically." is easier to understand. |
The original sounds weird to me (non-native too) I liked that the suggestion put the words "happens automatically" together It would be easier to read with commas. My suggestion |
Numeric conversion in mathematical functions and expressions happens automatically|? ;) |
It seems ok... |
@iliakan I have updated the PR with your suggestion. |
Will this make the idea more clear or the text more readable?
Replacing:
Numeric conversion happens in mathematical functions and expressions automatically.
With:
Numeric conversion in mathematical functions and expressions happen automatically.