Skip to content

Type Conversions #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Nov 27, 2022
Merged

Type Conversions #141

merged 30 commits into from
Nov 27, 2022

Conversation

Gabitzzz
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team November 26, 2022 03:21
@javascript-translate-bot javascript-translate-bot mentioned this pull request Nov 26, 2022
Open
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bogdanbacosca
bogdanbacosca requested changes Nov 26, 2022
View reviewed changes
Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per total traducerea este excelentă.
Cea mai des întâlnită greșeală a fost lipsa de diacritice.
Unele sugestii sunt subiective și opționale, putem discuta despre ele.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@bogdanbacosca
Copy link
Contributor

@Gabitzzz Am deschis un PR în versiunea originală en cu o sugestie din această traducere. Îl poți găsi aici: https://github.com/javascript-tutorial/en.javascript.info/pull/3278/files

Gabitzzz and others added 8 commits November 27, 2022 00:48
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
9ac94af 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
8084a93 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
4887660 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
6d21296 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
ecbea80 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
542fe33 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
cb3d429 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
6859bfe 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz Gabitzzz closed this Nov 27, 2022
@Gabitzzz Gabitzzz reopened this Nov 27, 2022
Gabitzzz
Gabitzzz commented Nov 27, 2022
View reviewed changes
Copy link
Contributor Author

@Gabitzzz Gabitzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modificari

@Gabitzzz
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team November 27, 2022 01:11
Gabitzzz and others added 13 commits November 27, 2022 01:16
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
91ba012 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
a997f19 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
b6bb4a3 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
6354489 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
b9daeaf 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
26d0690 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
042d40c 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
42c0af0 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
135b3de 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
b0a77b9 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/07-type-conversions/article.md
53543ca 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz
Update task.md
76a33db
@Gabitzzz
Update solution.md
4d82f99
bogdanbacosca
bogdanbacosca requested changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% gata. Lipsesc doar cateva diacritice. Perfect!

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

bogdanbacosca
bogdanbacosca approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall quite a good job, imagine 100 people like us doing this - insane! I really appreciate it.

@bogdanbacosca bogdanbacosca merged commit cd9bca6 into javascript-tutorial:master Nov 27, 2022
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabitzzz @CLAassistant @javascript-translate-bot @bogdanbacosca