Fix Double quotes does not trigger the autocomplete #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes laravel/vs-code-extension#339
If a last character is a double quote, for example:
then Microsoft\PhpParser\Parser::parseSourceFile returns autocompletingIndex: 1 instead 0. Example:
returns:
Comparison with a "single quote" example:
returns:
Probably the parser turns the string into something like this:
"{{ config(";"
and returns
";"
as an argument.This PR adds an extra check that the last character is a double quote. If so, replace it with a single quote.