Skip to content

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented Apr 12, 2024

Backport bd32aaa

Requested by: @wangpc-pp

@llvmbot llvmbot added this to the LLVM 18.X Release milestone Apr 12, 2024
@llvmbot
Copy link
Member Author

llvmbot commented Apr 12, 2024

@kito-cheng What do you think about merging this PR to the release branch?

@xermicus
Copy link
Contributor

compiler-rt doesn't build for RISC-V embedded targets without this patch so to me it'd make sense to backport :)

Copy link
Member

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Register spills (save/restore) in RISC-V embedded work differently
because there are less registers and different stack alignment.

[GCC equivalent
](https://github.com/gcc-mirror/gcc/blob/master/libgcc/config/riscv/save-restore.S#L298C16-L336)

Follow up from llvm#76777.

---------

Signed-off-by: xermicus <[email protected]>
(cherry picked from commit bd32aaa)
@tstellar tstellar merged commit eaae766 into llvm:release/18.x Apr 15, 2024
@tstellar
Copy link
Collaborator

Hi @wangpc-pp (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix.

@wangpc-pp
Copy link
Contributor

wangpc-pp commented Apr 16, 2024

Hi @wangpc-pp (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix.

Yeah, the description can be:

Save/restore routines for RV32E/RV64E are added to compiler-rt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants