Skip to content

Added missing translation for modal title & buttons on admin #28174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020
Merged

Added missing translation for modal title & buttons on admin #28174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/code/Magento/CatalogInventory/i18n/en_US.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,4 @@ Stock,Stock
"Use Config Settings","Use Config Settings"
"Qty Uses Decimals","Qty Uses Decimals"
"Allow Multiple Boxes for Shipping","Allow Multiple Boxes for Shipping"
"Done","Done"
4 changes: 2 additions & 2 deletions app/code/Magento/CatalogInventory/view/adminhtml/ui_component/product_form.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<options>
<option name="buttons" xsi:type="array">
<item name="0" xsi:type="array">
<item name="text" xsi:type="string">Done</item>
<item name="text" xsi:type="string" translate="true">Done</item>
<item name="class" xsi:type="string">action-primary</item>
<item name="actions" xsi:type="array">
<item name="0" xsi:type="array">
Expand All @@ -21,7 +21,7 @@
</item>
</item>
</option>
<option name="title" xsi:type="string">Advanced Inventory</option>
<option name="title" xsi:type="string" translate="true">Advanced Inventory</option>
</options>
<onCancel>actionDone</onCancel>
<dataScope>data.product</dataScope>
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/Customer/i18n/en_US.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,3 +541,4 @@ Addresses,Addresses
"The Date of Birth should not be greater than today.","The Date of Birth should not be greater than today."
"The store view is not in the associated website.","The store view is not in the associated website."
"The Store View selected for sending Welcome email from is not related to the customer's associated website.","The Store View selected for sending Welcome email from is not related to the customer's associated website."
"Add/Update Address","Add/Update Address"
2 changes: 1 addition & 1 deletion app/code/Magento/Customer/view/base/ui_component/customer_form.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@
<modal name="customer_address_update_modal">
<settings>
<options>
<option name="title" xsi:type="string">Add/Update Address</option>
<option name="title" xsi:type="string" translate="true">Add/Update Address</option>
</options>
</settings>
<insertForm name="update_customer_address_form_loader" component="Magento_Customer/js/form/components/insert-form">
Expand Down