Skip to content

DOCSP-45054: search index type #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

DOCSP-45054: search index type #580

merged 2 commits into from
Apr 24, 2025

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Apr 8, 2025 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45054

Staging Links

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?
  • Are the page titles greater than 20 characters long and SEO relevant?

@netlify Netlify
Copy link

netlify bot commented Apr 8, 2025 •
edited
Loading

✅ Deploy Preview for docs-csharp ready!

Name Link
🔨 Latest commit 10d7472
🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67f55e5d65c5b800079d4906
😎 Deploy Preview https://deploy-preview-580--docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir force-pushed the DOCSP-45054-type-for--search-idx branch from 1392c66 to a1ef3ed Compare April 8, 2025 15:25
mongoKart
mongoKart approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small change

@rustagir rustagir requested a review from adelinowona April 8, 2025 17:36
adelinowona
adelinowona approved these changes Apr 24, 2025
View reviewed changes
Copy link

@adelinowona adelinowona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustagir rustagir merged commit 518264b into mongodb:master Apr 24, 2025
6 checks passed
rustagir added a commit that referenced this pull request Apr 24, 2025
@rustagir
DOCSP-45054: search index type (#580)
cd72abd 
* DOCSP-45054: search index type

* MW small fix

(cherry picked from commit 518264b)
rustagir added a commit that referenced this pull request Apr 24, 2025
@rustagir
DOCSP-45054: search index type (#580)
2764da7 
* DOCSP-45054: search index type

* MW small fix

(cherry picked from commit 518264b)
rustagir added a commit that referenced this pull request Apr 24, 2025
@rustagir
DOCSP-45054: search index type (#580)
65c1472 
* DOCSP-45054: search index type

* MW small fix

(cherry picked from commit 518264b)
mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
@rustagir
DOCSP-45054: search index type (mongodb#580)
7cd199c 
* DOCSP-45054: search index type

* MW small fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelinowona adelinowona adelinowona approved these changes

@mongoKart mongoKart mongoKart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @adelinowona @mongoKart