-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-49849 - Collation #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docsp-45382-comp-cvg
Are you sure you want to change the base?
DOCSP-49849 - Collation #628
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could improve this:
source/includes/collation.rst
Outdated
- ``Locale`` | ||
|
||
* - ``alternate`` | ||
- | Optional. Specifies whether the driver considers whitespace and punctuation as base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other table in this doc set uses italics for *Optional.*
, but the style guide uses (*Optional)*
I'll leave it up to you.
source/includes/collation.rst
Outdated
|
||
* - ``alternate`` | ||
- | Optional. Specifies whether the driver considers whitespace and punctuation as base | ||
characters for purposes of comparison. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add an **Accepted Values:**
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of the C# enum data types, I linked to the relevant API page, which documents the possible options. Similar for the string types linking to a page with the accepted options.
source/includes/collation.rst
Outdated
- ``Backwards`` | ||
|
||
* - ``caseFirst`` | ||
- | Optional. Specifies the sort order of case differences during tertiary level comparisons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Accepted Values:**
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
source/includes/collation.rst
Outdated
- | Optional. Specifies whether to include case comparison at strength level ``Primary`` or | ||
``Secondary``. | ||
| | ||
| When this argument is ``true``: | ||
| | ||
| - If the strength is ``Primary``, the driver compares base | ||
characters and case. | ||
| - If the strength is ``Secondary``, the driver compares base | ||
characters, diacritics, other secondary differences, and case. | ||
| | ||
| When this argument is ``false``, the driver doesn't include case comparison at | ||
strength level ``Primary`` or ``Secondary``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a way to add a link to the strength parameter, I would do that here. I'm assuming this is why you were asking about nesting tables the other day, because that would make sense here.
- | Optional. Specifies whether to include case comparison at strength level ``Primary`` or | |
``Secondary``. | |
| | |
| When this argument is ``true``: | |
| | |
| - If the strength is ``Primary``, the driver compares base | |
characters and case. | |
| - If the strength is ``Secondary``, the driver compares base | |
characters, diacritics, other secondary differences, and case. | |
| | |
| When this argument is ``false``, the driver doesn't include case comparison at | |
strength level ``Primary`` or ``Secondary``. | |
- | Optional. Specifies whether to include case comparison. | |
| | |
| When this argument is ``true``, the behaviour depends on the value of the ``Strength`` property: | |
| | |
| - If the ``Strength`` property is ``Primary``, the driver compares base | |
characters and case. | |
| - If the ``Strength`` property is ``Secondary``, the driver compares base | |
characters, diacritics, other secondary differences, and case. | |
| | |
| When this argument is ``false``, the driver doesn't include case comparison. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know of a way to link to another table row. I could move strength above caseLevel but I just moved them to parameter order and that would throw it off.
a note about the properties: they're read-only and set directly by these parameters, so i talk about the values of the parameters instead of the values of the properties.
source/includes/collation.rst
Outdated
- | Optional. Specifies which characters the driver considers ignorable when | ||
``Alternate`` is ``CollationAlternate.Shifted``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add **Accepted Values:**
- | Optional. Specifies which characters the driver considers ignorable when | |
``Alternate`` is ``CollationAlternate.Shifted``. | |
- | Optional. Specifies which characters the driver considers ignorable when the | |
``Alternate`` property is ``CollationAlternate.Shifted``. |
source/includes/collation.rst
Outdated
- ``MaxVariable`` | ||
|
||
* - ``normalization`` | ||
- | Optional. Specifies whether the driver normalizes text as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about a link to the ICU docs
source/includes/collation.rst
Outdated
| If this argument is ``true``, the driver compares numeric strings as numbers. | ||
For example, "10" is greater than "2". If this argument is ``false`` or excluded, | ||
the driver compares numeric strings as strings. For example, "10" is less than "2". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're not being treated as strings so I would leave out the "s, you could make them 10
and 2
if you want to differentiate them:
| If this argument is ``true``, the driver compares numeric strings as numbers. | |
For example, "10" is greater than "2". If this argument is ``false`` or excluded, | |
the driver compares numeric strings as strings. For example, "10" is less than "2". | |
| If this argument is ``true``, the driver compares numeric strings as numbers. | |
For example, 10 is greater than 2. | |
| | |
| If this argument is ``false`` or excluded, | |
the driver compares numeric strings as strings. For example, "10" is less than "2". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they aren't being compared as strings, but they still are strings, so i think the quotes are useful. lmk if this change is clearer.
source/includes/collation.rst
Outdated
For more information about collation, see the :manual:`Collation <reference/collation>` | ||
page in the {+mdb-server+} manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404
For more information about collation, see the :manual:`Collation <reference/collation>` | |
page in the {+mdb-server+} manual. | |
For more information about collation, see the :manual:`Collation </reference/collation>` | |
page in the {+mdb-server+} manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's the page template for update-many and update-one
I wanted to incorporate this into the Server docs but it didn't fit there neatly.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49849
Staging Links
Self-Review Checklist