Improve shebang compatability and quote file paths

addRemoteOrigin.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 clear
 echo "-------- Add remote origin for all directories --------------"
 
@@ -27,9 +27,9 @@ ORGANIZATION="mdn"
 for i in "${repositories[@]}"
 do
   echo "git remote add upstream https://github.com/${ORGANIZATION}/$i.git"
-  cd ${SYSTEM_DIR}/$i 
+  cd "${SYSTEM_DIR}/$i"
   git branch
-  git remote add upstream https://github.com/${ORGANIZATION}/$i.git
+  git remote add upstream "https://github.com/${ORGANIZATION}/$i.git"
 done
 
 

createDIRwithMD.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # START ----------------------------
 #
@@ -26,7 +26,7 @@ goToCorrectDirectory () {
 
   path="${SYSTEM_DIR}${REPO_PATH}${sub_path}"
 
-  cd ${path}
+  cd "${path}"
   echo "Selected Directory:"
   pwd
   echo "Is that correct? (y/n/x for exit)"
@@ -50,9 +50,9 @@ createDocuments () {
     echo "Sorry, that folder already exists. Try again."
     createDocuments
   else
-    mkdir ${newFileName}
+    mkdir "${newFileName}"
     # create an index.md in that folder
-    touch ${newFileName}/index.md
+    touch "${newFileName}/index.md"
     addContent  
   fi
 # Ask user to enter a new folder name or exit?
@@ -82,7 +82,7 @@ addContent () {
   export usefulFileName=${newFileName//_/ }
   export sectionTitle=(${words[${length}-2]//_// })
 
-  cat > ${newFileName}/index.md <<- EOM
+  cat > "${newFileName}/index.md" <<- EOM
 ---
 title: '${sectionTitle}: ${usefulFileName}'
 slug: Web${sub_path}/${newFileName}
@@ -109,4 +109,4 @@ goToCorrectDirectory
 echo "We're in the right directory. Now let's create the files"
 
 # then create the folders and index files
-createDocuments
+createDocuments

pushCurrentAndBase.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # run after fetching upstream
 # ~/scripts/startFresh.sh

startFresh.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 clear
 echo "-------- Update all repos! --------------"
 
@@ -25,7 +25,7 @@ path=''
 for i in "${repositories[@]}"
   do
     path="${SYSTEM_DIR}/$i"
-    cd ${path}
+    cd "${path}"
 
     #content has different origing
     if [[ i == content ]]

upstreamAllRepos.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 clear
 echo "-------- Update all repos! --------------"
 
@@ -34,7 +34,7 @@ path=''
 for i in "${repositories[@]}"
   do
     path="${SYSTEM_DIR}/$i"
-    cd ${path}
+    cd "${path}"
 
     #check if the repo has a default 'main branch'
     if [[ ${mainBranch[*]} =~ $i ]]
@@ -53,4 +53,4 @@ for i in "${repositories[@]}"
 done
 
 # if you like your computer to talk to you
-# say "Mission Accomplished"
+# say "Mission Accomplished"