Skip to content

[PGPRO-5360] Fix for freeze (Valgrind and compilation with -Og option) #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

kovdb75
Copy link
Collaborator

@kovdb75 kovdb75 commented Jul 13, 2022

Sometimes pg_patman is freezes for 1 min (in case it started unde Valgrind and complied with -Og option).
This change (for variable failures_count) fixes it.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #251 (66da266) into master (afddc65) will increase coverage by 0.42%.
The diff coverage is 100.00%.

❗ Current head 66da266 differs from pull request most recent head f135090. Consider uploading reports for the commit f135090 to get more accurate results

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   91.46%   91.89%   +0.42%     
==========================================
  Files          43       33      -10     
  Lines        7266     6562     -704     
==========================================
- Hits         6646     6030     -616     
+ Misses        620      532      -88     
Impacted Files Coverage Δ
src/pathman_workers.c 84.94% <100.00%> (+0.91%) ⬆️
src/pg_pathman.c 93.40% <0.00%> (-1.79%) ⬇️
src/planner_tree_modification.c 86.96% <0.00%> (-1.56%) ⬇️
src/include/compat/pg_compat.h 92.30% <0.00%> (-1.03%) ⬇️
src/utils.c 92.10% <0.00%> (-0.66%) ⬇️
src/init.c 91.02% <0.00%> (-0.30%) ⬇️
src/compat/pg_compat.c 74.41% <0.00%> (-0.20%) ⬇️
src/runtime_merge_append.c 69.51% <0.00%> (-0.18%) ⬇️
src/xact_handling.c 90.74% <0.00%> (-0.17%) ⬇️
src/partition_filter.c 96.44% <0.00%> (-0.14%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afddc65...f135090. Read the comment docs.

@funny-falcon funny-falcon merged commit 73e3a35 into master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants