Skip to content

Fixes related to new changes in PostgreSQL 16: October 25, 2022 - November 15, 2022 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2022
Merged

Fixes related to new changes in PostgreSQL 16: October 25, 2022 - November 15, 2022 #259

merged 3 commits into from
Dec 14, 2022

Conversation

MarinaPolyakova
Copy link
Contributor

The commit d353625 was added to fix regression.diffs after running the tests:

diff -U3 /home/marina/pg_pathman/expected/pathman_join_clause_2.out /home/marina/pg_pathman/results/pathman_join_clause.out
--- /home/marina/pg_pathman/expected/pathman_join_clause_2.out	2022-11-21 14:11:54.399449877 +0300
+++ /home/marina/pg_pathman/results/pathman_join_clause.out	2022-12-14 09:14:34.999078710 +0300
@@ -44,23 +44,23 @@
  Nested Loop
    ->  Seq Scan on fk
    ->  Custom Scan (RuntimeAppend)
-         Prune by: (fk.id1 = m.id1)
+         Prune by: (m.id1 = fk.id1)
          ->  Seq Scan on mytbl_0 m
-               Filter: ((fk.id1 = id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
+               Filter: ((id1 = fk.id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
          ->  Seq Scan on mytbl_1 m
-               Filter: ((fk.id1 = id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
+               Filter: ((id1 = fk.id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
          ->  Seq Scan on mytbl_2 m
-               Filter: ((fk.id1 = id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
+               Filter: ((id1 = fk.id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
          ->  Seq Scan on mytbl_3 m
-               Filter: ((fk.id1 = id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
+               Filter: ((id1 = fk.id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
          ->  Seq Scan on mytbl_4 m
-               Filter: ((fk.id1 = id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
+               Filter: ((id1 = fk.id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
          ->  Seq Scan on mytbl_5 m
-               Filter: ((fk.id1 = id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
+               Filter: ((id1 = fk.id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
          ->  Seq Scan on mytbl_6 m
-               Filter: ((fk.id1 = id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
+               Filter: ((id1 = fk.id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
          ->  Seq Scan on mytbl_7 m
-               Filter: ((fk.id1 = id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
+               Filter: ((id1 = fk.id1) AND (fk.id2 = id2) AND (NOT (key <@ int4range(6, fk.end_key))))
 (20 rows)
 
 /* test joint data */
diff -U3 /home/marina/pg_pathman/expected/pathman_lateral_2.out /home/marina/pg_pathman/results/pathman_lateral.out
--- /home/marina/pg_pathman/expected/pathman_lateral_2.out	2022-11-21 14:11:54.399449877 +0300
+++ /home/marina/pg_pathman/results/pathman_lateral.out	2022-12-14 09:14:35.351061632 +0300
@@ -97,7 +97,7 @@
                                  ->  Seq Scan on data_9 t1_10
                                        Filter: ((id >= 1) AND (id <= 100))
    ->  Custom Scan (RuntimeAppend)
-         Prune by: (t_1.id = t3.id)
+         Prune by: (t3.id = t_1.id)
          ->  Seq Scan on data_0 t3
                Filter: (t_1.id = id)
          ->  Seq Scan on data_1 t3
diff -U3 /home/marina/pg_pathman/expected/pathman_only_2.out /home/marina/pg_pathman/results/pathman_only.out
--- /home/marina/pg_pathman/expected/pathman_only_2.out	2022-11-21 14:11:54.399449877 +0300
+++ /home/marina/pg_pathman/results/pathman_only.out	2022-12-14 09:14:36.207020217 +0300
@@ -150,7 +150,7 @@
  Nested Loop
    ->  Seq Scan on from_only_test b
    ->  Custom Scan (RuntimeAppend)
-         Prune by: (b.val = a.val)
+         Prune by: (a.val = b.val)
          ->  Seq Scan on from_only_test_1 a
                Filter: (b.val = val)
          ->  Seq Scan on from_only_test_2 a
@@ -183,7 +183,7 @@
  Nested Loop
    ->  Seq Scan on from_only_test from_only_test_1
    ->  Custom Scan (RuntimeAppend)
-         Prune by: (from_only_test_1.val = from_only_test.val)
+         Prune by: (from_only_test.val = from_only_test_1.val)
          ->  Seq Scan on from_only_test_1 from_only_test
                Filter: (from_only_test_1.val = val)
          ->  Seq Scan on from_only_test_2 from_only_test
@@ -215,7 +215,7 @@
  Nested Loop
    ->  Seq Scan on from_only_test from_only_test_1
    ->  Custom Scan (RuntimeAppend)
-         Prune by: (from_only_test_1.val = from_only_test.val)
+         Prune by: (from_only_test.val = from_only_test_1.val)
          ->  Seq Scan on from_only_test_1 from_only_test
                Filter: (from_only_test_1.val = val)
          ->  Seq Scan on from_only_test_2 from_only_test
diff -U3 /home/marina/pg_pathman/expected/pathman_runtime_nodes.out /home/marina/pg_pathman/results/pathman_runtime_nodes.out
--- /home/marina/pg_pathman/expected/pathman_runtime_nodes.out	2022-11-21 14:11:54.399449877 +0300
+++ /home/marina/pg_pathman/results/pathman_runtime_nodes.out	2022-12-14 09:14:40.970796775 +0300
@@ -323,9 +323,9 @@
    ->  Limit
          ->  Seq Scan on run_values
    ->  Custom Scan (RuntimeAppend)
-         Prune by: (run_values.val = t1.id)
+         Prune by: (t1.id = run_values.val)
          ->  Seq Scan on runtime_test_1 t1
-               Filter: (run_values.val = id)
+               Filter: (id = run_values.val)
          ->  Index Only Scan using runtime_test_1_0_pkey on runtime_test_1_0 t1
                Index Cond: (id = run_values.val)
          ->  Index Only Scan using runtime_test_1_1_pkey on runtime_test_1_1 t1
@@ -361,7 +361,7 @@
    ->  Limit
          ->  Seq Scan on run_values
    ->  Custom Scan (RuntimeAppend)
-         Prune by: (run_values.val = t1.id)
+         Prune by: (t1.id = run_values.val)
          ->  Index Only Scan using runtime_test_1_0_pkey on runtime_test_1_0 t1
                Index Cond: (id = run_values.val)
          ->  Index Only Scan using runtime_test_1_1_pkey on runtime_test_1_1 t1

I'm only assuming that the commit a5fc46414deb7cbcd4cec1275efac69b9ac10500 (Avoid making
commutatively-duplicate clauses in EquivalenceClasses.) caused these changes.

@codecov
Copy link

codecov bot commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #259 (364d200) into master (8ccd9e8) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files          30       30           
  Lines        6735     6735           
=======================================
  Hits         6224     6224           
  Misses        511      511
Impacted Files Coverage Δ
src/compat/pg_compat.c 77.52% <ø> (ø)
src/init.c 91.07% <0.00%> (ø)
src/nodes_common.c 97.22% <ø> (ø)
src/partition_creation.c 96.81% <ø> (ø)
src/partition_router.c 85.02% <ø> (ø)
src/relation_info.c 94.30% <ø> (ø)
src/pg_pathman.c 95.48% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Marina Polyakova added 3 commits December 14, 2022 12:53
@kovdb75
Remove AssertArg and AssertState
2b286c4 
See the commit b1099eca8f38ff5cfaf0901bb91cb6a22f909bc6 (Remove AssertArg and
AssertState) in PostgreSQL 16.
@kovdb75
Fix pg_pathman_enable_partition_router initial value
e32efa8 
Thus it is equal to its boot value. See the commit
a73952b795632b2cf5acada8476e7cf75857e9be (Add check on initial and boot values
when loading GUCs) in PostgreSQL 16.
@kovdb75
Avoid making commutatively-duplicate clauses in EquivalenceClasses.
364d200 
See the commit a5fc46414deb7cbcd4cec1275efac69b9ac10500 (Avoid making
commutatively-duplicate clauses in EquivalenceClasses.) in PostgreSQL 16.
@kovdb75 kovdb75 merged commit 3fae863 into master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kovdb75 kovdb75 Awaiting requested review from kovdb75

Assignees

@kovdb75 kovdb75

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarinaPolyakova @kovdb75