Skip to content

[BUG FIX] PostgresNode must use get_pg_version2 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

[BUG FIX] PostgresNode must use get_pg_version2 #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions testgres/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
PgVer, \
eprint, \
get_bin_path2, \
get_pg_version, \
get_pg_version2, \
execute_utility2, \
options_string, \
clean_on_error
Expand Down Expand Up @@ -148,16 +148,6 @@ def __init__(self, name=None, base_dir=None, port=None, conn_params: ConnectionP
"""

# private
self._pg_version = PgVer(get_pg_version(bin_dir))
self._should_free_port = port is None
self._base_dir = base_dir
self._bin_dir = bin_dir
self._prefix = prefix
self._logger = None
self._master = None

# basic
self.name = name or generate_app_name()
if os_ops is None:
os_ops = __class__._get_os_ops(conn_params)
else:
Expand All @@ -168,6 +158,17 @@ def __init__(self, name=None, base_dir=None, port=None, conn_params: ConnectionP
assert isinstance(os_ops, OsOperations)
self._os_ops = os_ops

self._pg_version = PgVer(get_pg_version2(os_ops, bin_dir))
self._should_free_port = port is None
self._base_dir = base_dir
self._bin_dir = bin_dir
self._prefix = prefix
self._logger = None
self._master = None

# basic
self.name = name or generate_app_name()

self.host = os_ops.host
self.port = port or utils.reserve_port()

Expand Down