Skip to content

Revert "PBCKP-377 optionaly keep test logs" #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023
Merged

Revert "PBCKP-377 optionaly keep test logs" #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions testgres/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,15 +875,13 @@ def free_port(self):
self._should_free_port = False
release_port(self.port)

def cleanup(self, max_attempts=3, full_clean=testgres_config.node_cleanup_full):
def cleanup(self, max_attempts=3):
"""
Stop node if needed and remove its data/logs directory.
NOTE: take a look at TestgresConfig.node_cleanup_full.

Args:
max_attempts: how many times should we try to stop()?
full_clean: True - clean all node data
False - clean only data dir, save logs

Returns:
This instance of :class:`.PostgresNode`.
Expand All @@ -892,7 +890,7 @@ def cleanup(self, max_attempts=3, full_clean=testgres_config.node_cleanup_full):
self._try_shutdown(max_attempts)

# choose directory to be removed
if full_clean:
if testgres_config.node_cleanup_full:
rm_dir = self.base_dir # everything
else:
rm_dir = self.data_dir # just data, save logs
Expand Down