Add some notes on repetition #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Havvy
suggested changes
Sep 22, 2018
src/macros-by-example.md
Outdated
| @@ -59,6 +59,10 @@ matches, in a structure that mimics the structure of the repetition encountered | |||
| on a successful match. The job of the transcriber is to sort that structure | |||
| out. | |||
|
|
|||
| > **Edition Differences**: In the 2018 edition, a new Kleene operator was | |||
There was a problem hiding this comment.
What ? means should be defined outside of the edition differences section. And then the edition differences section should just state that it's not available in the 2015 edition.
|
@Havvy better now? |
Havvy
approved these changes
Sep 27, 2018
|
💟 Thanks! Looking at the tracking issue, I think this is already stable in nightly Rust. If it's not, we can revert the two commits. |
|
@Havvy Thanks! But it is actually unstable still: https://play.rust-lang.org/?gist=af7cee08e596c9d7b61fa4f276134205&version=nightly&mode=debug&edition=2018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust#51934
The new Kleene op is not stable yet, but the removal of
?as a separator is. I can split this up into two PRs if you want.