update UB #659
Merged
update UB #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnzlbg
reviewed
Aug 25, 2019
gnzlbg
reviewed
Aug 25, 2019
gnzlbg
reviewed
Aug 25, 2019
Centril
reviewed
Aug 25, 2019
|
I adjusted the text to fix the slice issue that came up. |
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
RalfJung
commented
Aug 27, 2019
gnzlbg
reviewed
Aug 27, 2019
gnzlbg
reviewed
Aug 27, 2019
|
I think I resolved all comments. |
gnzlbg
approved these changes
Aug 27, 2019
RalfJung
commented
Aug 29, 2019
Centril
reviewed
Aug 29, 2019
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
|
@Centril Is there anything left here, or can it be merged? |
Centril
approved these changes
Sep 5, 2019
This was referenced Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs the Reference definition of UB with what the Nomicon has recently been updated to, including the still-under-review changes in rust-lang/nomicon#162.
Cc @Centril @Gankra