Skip to content

Conversation

JhonnyBillM
Copy link
Contributor

Module is complete. It doesn’t have any diagnostics.

Module is completed because it doesn’t have any diagnostics
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 18, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022
@JhonnyBillM
Copy link
Contributor Author

r? @compiler-errors @davidtwco

@JhonnyBillM JhonnyBillM mentioned this pull request Aug 18, 2022
84 tasks
@JhonnyBillM JhonnyBillM changed the title Add diagnostics lints to rustc_type_ir module Add diagnostics lints to rustc_type_ir and rustc_symbol_mangling modules Aug 18, 2022
@rust-log-analyzer

This comment has been minimized.

@JhonnyBillM JhonnyBillM force-pushed the enable-diag-lint-in-type-ir branch from fb88eb3 to 05ed13b Compare August 18, 2022 17:51
@JhonnyBillM JhonnyBillM changed the title Add diagnostics lints to rustc_type_ir and rustc_symbol_mangling modules Add diagnostics lints to rustc_type_ir module Aug 18, 2022
@compiler-errors compiler-errors added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Aug 18, 2022
@compiler-errors
Copy link
Member

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Aug 18, 2022

📌 Commit 05ed13b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 19, 2022
Rollup of 9 pull requests

Successful merges:

 - rust-lang#99576 (Do not allow `Drop` impl on foreign fundamental types)
 - rust-lang#100081 (never consider unsafe blocks unused if they would be required with deny(unsafe_op_in_unsafe_fn))
 - rust-lang#100208 (make NOP dyn casts not require anything about the vtable)
 - rust-lang#100494 (Cleanup rustdoc themes)
 - rust-lang#100522 (Only check the `DefId` for the recursion check in MIR inliner.)
 - rust-lang#100592 (Manually implement Debug for ImportKind.)
 - rust-lang#100598 (Don't fix builtin index when Where clause is found)
 - rust-lang#100721 (Add diagnostics lints to `rustc_type_ir` module)
 - rust-lang#100731 (rustdoc: count deref and non-deref as same set of used methods)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 30e65ce into rust-lang:master Aug 19, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 19, 2022
@JhonnyBillM JhonnyBillM deleted the enable-diag-lint-in-type-ir branch August 20, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants