Fix ICE report flags display. #101595
Merged
Fix ICE report flags display. #101595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#101413 (Use RelocModel::Pic for UEFI targets) - rust-lang#101595 (Fix ICE report flags display.) - rust-lang#101616 (Adapt test for msan message change) - rust-lang#101624 (rustdoc: remove unused CSS `#search { position: relative }`) - rust-lang#101633 (Rustdoc-Json: Correcty handle intra-doc-links to items without HTML page) - rust-lang#101634 (Rustdoc-Json Tests: Use ``@is`` and ``@ismany`` more often.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#92310 made some changes to the ICE report that displays the rustc flags, but it introduced a bug where a flag like
-Z incremental-verify-ich=yeswas being treated as-if it was-Cincremental. This corrupted the output and made it confusing. The cause was usingstarts_withinstead of properly splitting the option.For example, with the command like
rustc foo.rs -Cincremental=/tmp/a -Zincremental-verify-ich=yes --crate-type libwould previously look like:It now looks like:
I added a
[REDACTED]marker for-Cincrementalso it is a little less confusing that a value has been removed.Fixes #101588