Skip to content

Conversation

saethlin
Copy link
Member

The standard library has a lot more debug assertions since #92686 which also found and fixed some UB in the compiler using them. It has been suggested that as a follow-up to trying out the LLVM assertions in #101591, we try out the Rust assertions.

I think this would only need a check run.

@rust-highfive
Copy link
Contributor

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Sep 17, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2022
@pietroalbini
Copy link
Member

@bors try

@bors
Copy link
Collaborator

bors commented Sep 18, 2022

⌛ Trying commit ca14fbe with merge 3bbb5242a8064de4ca3af4036745ddf603ddaa85...

@bors
Copy link
Collaborator

bors commented Sep 18, 2022

☀️ Try build successful - checks-actions
Build commit: 3bbb5242a8064de4ca3af4036745ddf603ddaa85 (3bbb5242a8064de4ca3af4036745ddf603ddaa85)

@pietroalbini
Copy link
Member

@craterbot run mode=build-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-101929 created and queued.
🤖 Automatically detected try build 3bbb5242a8064de4ca3af4036745ddf603ddaa85
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment pr-101929 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-101929 is completed!
📊 224 regressed and 3 fixed (243718 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 20, 2022
@saethlin
Copy link
Member Author

Looks like the majority of these are SIGILL crashes in either syntex_syntax which is an old and deprecated crate, rle-decode-fast version 1.0.1, and clang's 1.0 series. The first two are doing out-of-bounds unchecked indexing, and clang creates null slices. There's also one showing from font-kit's null slices, always nice to see an old friend.

It looks like the rest of the regressions are OOMs of some kind or another.

I reported what looks like the single net-new finding here: #102074

There are also plenty of other ICEs in here, but nothing new as best I can tell. I think this matter is closed.

@saethlin saethlin closed this Sep 20, 2022
@saethlin saethlin deleted the turn-on-debug branch September 21, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants