Skip to content

Conversation

reez12g
Copy link
Contributor

@reez12g reez12g commented Sep 18, 2022

Fixes #101306

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 18, 2022
@rust-highfive
Copy link
Contributor

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2022
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2022
@jyn514 jyn514 marked this pull request as ready for review September 30, 2022 15:51
@jyn514
Copy link
Member

jyn514 commented Sep 30, 2022

@bors delegate=reez12g

@bors
Copy link
Collaborator

bors commented Sep 30, 2022

✌️ @reez12g can now approve this pull request

@reez12g
Copy link
Contributor Author

reez12g commented Oct 1, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 1, 2022

📌 Commit 9f201d6 has been approved by reez12g

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2022
@bors
Copy link
Collaborator

bors commented Oct 1, 2022

⌛ Testing commit 9f201d6 with merge c5b105d...

@bors
Copy link
Collaborator

bors commented Oct 1, 2022

☀️ Test successful - checks-actions
Approved by: reez12g
Pushing c5b105d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 1, 2022
@bors bors merged commit c5b105d into rust-lang:master Oct 1, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 1, 2022
@reez12g reez12g deleted the issue-101306 branch October 1, 2022 04:00
@TimNN
Copy link
Contributor

TimNN commented Oct 1, 2022

I believe this breaks the clean subcommand, due to this panic:

panic!()
(See also this custom CI bot).

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c5b105d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)
-3.6% [-3.6%, -3.6%] 1
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.6% [2.1%, 5.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.4% [-4.4%, -4.4%] 1
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustfmt Not Downloaded Until Manual x.py fmt
7 participants