Don't display function path for unsafe_op_in_unsafe_fn lints
#106127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
b01e345 to
2f739ec
Compare
|
Alternatively, #106157 disables path trimming. Unsure of which solution is preferred. |
|
r? rust-lang/compiler |
|
How do other lints that print paths handle this? I think we should try to align with them if possible. Showing the path seems pretty nice to me and I would prefer having it, not trimming it doesn't sound too bad given that it's just a function. |
|
Closing in favor of #106157 as discussed on Zulip. Thanks @Nilstrieb |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 4, 2023
…ck-good-path-bug-2, r=compiler-errors Don't trim path for `unsafe_op_in_unsafe_fn` lints Fixes rust-lang#106126, alternative to rust-lang#106127. r? `@ghost` for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106126, partially reverts #96294.