Skip to content

Conversation

GuillaumeGomez
Copy link
Member

From the experiment #103985.

cc @compiler-errors
r? @oli-obk

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2023
@GuillaumeGomez GuillaumeGomez force-pushed the projection-as-union-field-type branch from 321272a to b2cf45b Compare January 13, 2023 13:26
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 13, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jan 13, 2023

Was there an attempt to fix this by normalizing $somewhere?

@@ -0,0 +1,18 @@
// This is currently not possible to use projections as union field's type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be in an appropriate subdirectory. I think we have a union directory?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it should either have an accompanying .stderr file or a known-bug header and no error annotations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My rebase was a huge failure... ^^'

@GuillaumeGomez
Copy link
Member Author

Was there an attempt to fix this by normalizing $somewhere?

That's what I asked on zulip. I guess it should be normalized then. Investigating.

@GuillaumeGomez GuillaumeGomez force-pushed the projection-as-union-field-type branch from b2cf45b to 829cf09 Compare January 13, 2023 14:40
@GuillaumeGomez GuillaumeGomez deleted the projection-as-union-field-type branch January 16, 2023 14:21
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2023
…field-ty, r=oli-obk

Add missing normalization for union fields types

Overshadows rust-lang#106808.
From the experiment rust-lang#103985.

In short, it allows to use projections as a type for union's fields.

cc `@compiler-errors`
r? `@oli-obk`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Feb 11, 2023
… r=oli-obk

Add missing normalization for union fields types

Overshadows rust-lang/rust#106808.
From the experiment rust-lang/rust#103985.

In short, it allows to use projections as a type for union's fields.

cc `@compiler-errors`
r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants