Skip to content

Conversation

aliemjay
Copy link
Member

@aliemjay aliemjay commented Jan 22, 2023

This FIXME was introduced in c6a17bf but it should've been restricted to ascribe_user_type_skip_wf.

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 22, 2023
@aliemjay aliemjay marked this pull request as ready for review January 22, 2023 14:24
@compiler-errors
Copy link
Member

r? types

@rustbot rustbot assigned jackh726 and unassigned wesleywiser Jan 22, 2023
@jackh726
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jan 29, 2023

📌 Commit 9346eb6 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023
@jackh726
Copy link
Member

(Not rolling up for bisectability, given how easy it is for normalization things to mess things up)

@bors
Copy link
Collaborator

bors commented Jan 30, 2023

⌛ Testing commit 9346eb6 with merge 2ef759353a028da14550ee904a2ce19db58edb81...

@bors
Copy link
Collaborator

bors commented Jan 30, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2023
@jackh726
Copy link
Member

@bors retry seems spurious

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2023
@bors
Copy link
Collaborator

bors commented Jan 30, 2023

⌛ Testing commit 9346eb6 with merge 001a77f...

@rust-log-analyzer
Copy link
Collaborator

The job i686-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[2621/3021] Linking CXX static library lib\libLLVMWebAssemblyAsmParser.a
[2622/3021] Linking CXX static library lib\libLLVMRISCVCodeGen.a
[2623/3021] Linking CXX static library lib\libLLVMAArch64CodeGen.a
[2624/3021] Linking CXX static library lib\libLLVMX86CodeGen.a
FAILED: lib/libLLVMX86CodeGen.a 
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E rm -f lib\libLLVMX86CodeGen.a && D:\a\rust\rust\mingw32\bin\ar.exe qc lib\libLLVMX86CodeGen.a  lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86AsmPrinter.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86AvoidTrailingCall.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86CallFrameOptimization.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86CallingConv.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86CallLowering.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86CmovConversion.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86DomainReassignment.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86DiscriminateMemOps.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LowerTileCopy.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LowerAMXType.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86PreAMXConfig.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LowerAMXIntrinsics.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86TileConfig.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FastPreTileConfig.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FastTileConfig.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86PreTileConfig.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86ExpandPseudo.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FastISel.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FixupBWInsts.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FixupLEAs.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86AvoidStoreForwardingBlocks.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86DynAllocaExpander.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FixupSetCC.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FlagsCopyLowering.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FloatingPoint.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FrameLowering.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InstructionSelector.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86ISelDAGToDAG.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86ISelLowering.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86IndirectBranchTracking.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86IndirectThunks.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InterleavedAccess.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InsertPrefetch.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InstCombineIntrinsic.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InstrFMA3Info.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InstrFoldTables.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InstrInfo.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86EvexToVex.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LegalizerInfo.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LoadValueInjectionLoadHardening.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LoadValueInjectionRetHardening.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86MCInstLower.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86MachineFunctionInfo.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86MacroFusion.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86OptimizeLEAs.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86PadShortFunction.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86PartialReduction.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86RegisterBankInfo.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86RegisterInfo.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86ReturnThunks.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86SelectionDAGInfo.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86ShuffleDecodeConstantPool.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86SpeculativeLoadHardening.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86SpeculativeExecutionSideEffectSuppression.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86Subtarget.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86TargetMachine.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86TargetObjectFile.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86TargetTransformInfo.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86VZeroUpper.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86WinEHState.cpp.obj lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InsertWait.cpp.obj && D:\a\rust\rust\mingw32\bin\ranlib.exe lib\libLLVMX86CodeGen.a && cd ."
D:\a\rust\rust\mingw32\bin\ar.exe: could not create temporary file whilst writing archive: no more archived files
[2625/3021] Linking CXX static library lib\libLLVMSparcCodeGen.a
[2626/3021] Linking CXX static library lib\libLLVMWebAssemblyDesc.a
[2627/3021] Linking CXX static library lib\libLLVMSystemZCodeGen.a
[2628/3021] Linking CXX static library lib\libLLVMAVRCodeGen.a
[2628/3021] Linking CXX static library lib\libLLVMAVRCodeGen.a
[2629/3021] Linking CXX static library lib\libLLVMM68kCodeGen.a
[2630/3021] Linking CXX executable bin\llvm-profdata.exe
[2631/3021] Linking CXX static library lib\libLLVMPasses.a
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\github.com-1285ae84e5963aae\cmake-0.1.48\src\lib.rs:975:5
 finished in 283.482 seconds
Build completed unsuccessfully in 0:08:02
Build completed unsuccessfully in 0:08:02
make: *** [Makefile:78: ci-mingw-subset-1] Error 1

@bors
Copy link
Collaborator

bors commented Jan 30, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 001a77f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 30, 2023
@bors bors merged commit 001a77f into rust-lang:master Jan 30, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 30, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (001a77f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.2% [4.1%, 4.3%] 2
Regressions ❌
(secondary)
3.9% [2.2%, 5.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.2% [4.1%, 4.3%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@aliemjay aliemjay deleted the patch-2 branch January 31, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants