Pass arguments to x subcommands with --
#107905
Merged
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have time for reviews right now, sorry. r? bootstrap |
|
This change would come almost for free with #108083, maybe you should add this change in the other PR. |
|
That's my plan for #107848 as well, I'll do that if you think the clap migration is likely to be accepted EDIT: added in a new commit |
|
I think this still has value to land now. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#104068 (rustdoc: Add PartialOrd trait to doc comment explanation) - rust-lang#107489 (Implement partial support for non-lifetime binders) - rust-lang#107905 (Pass arguments to `x` subcommands with `--`) - rust-lang#108009 (Move some tests) - rust-lang#108086 (wasm: Register the `relaxed-simd` target feature) - rust-lang#108104 (don't into self) - rust-lang#108133 (Small cleanups around `EarlyBinder`) - rust-lang#108136 (Do not ICE on unmet trait alias impl bounds) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107375
Any arguments passed to
xfollowing--are removed and not parsed, instead passed down to subcommands (just the ones listed in the issue, not sure if more are needed). This does not remove the existing--argsand--test-argsbehaviour, just extends it. It's also not documented in the help, not sure of the best way to format it.r? @jyn514