Consider target_family as pal #108917
Merged
Consider target_family as pal #108917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently tidy does not consider code in target_family as platform-specific. I think this is erroneous and should be fixed. Signed-off-by: Ayush Singh <[email protected]>
|
Excellent! I would like to see this exception removed but adding the proper tidy check is certainly "step one" here. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#106915 (Only load one CSS theme by default) - rust-lang#108294 (Place binder correctly for arbitrary trait bound suggestion) - rust-lang#108778 (x fmt: Don't print all modified files if there's more than 10) - rust-lang#108854 (feat/refactor: improve errors in case of ident with number at start) - rust-lang#108870 (Fix invalid inlining of reexport of reexport of private item) - rust-lang#108917 (Consider target_family as pal) - rust-lang#108922 (Add auto notification for changes to stable mir) - rust-lang#108929 (Fix typo in span_map.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 11, 2023
…bilee Move __thread_local_inner to sys Move `__thread_local_inner` macro in `crate::thread::local` to `crate::sys`. Initially, I was thinking about removing this macro completely, but I could not find a way to create the generic statics without macros, so in the end, I just moved to code around. This probably will need a rebase once rust-lang#108917 is merged r? `@workingjubilee`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 11, 2023
…bilee Move __thread_local_inner to sys Move `__thread_local_inner` macro in `crate::thread::local` to `crate::sys`. Initially, I was thinking about removing this macro completely, but I could not find a way to create the generic statics without macros, so in the end, I just moved to code around. This probably will need a rebase once rust-lang#108917 is merged r? ``@workingjubilee``
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
Jun 1, 2023
Move __thread_local_inner to sys Move `__thread_local_inner` macro in `crate::thread::local` to `crate::sys`. Initially, I was thinking about removing this macro completely, but I could not find a way to create the generic statics without macros, so in the end, I just moved to code around. This probably will need a rebase once rust-lang/rust#108917 is merged r? ``@workingjubilee``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tidy does not consider code in target_family as platform-specific. This is erroneous and should be fixed.
r? @workingjubilee