Ignore Inlined spans when computing caller location.
#109307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
compiler-errors
approved these changes
Mar 18, 2023
| @@ -880,7 +880,7 @@ impl Span { | |||
| pub fn fresh_expansion(self, expn_id: LocalExpnId) -> Span { | |||
| HygieneData::with(|data| { | |||
| self.with_ctxt(data.apply_mark( | |||
| SyntaxContext::root(), | |||
| self.ctxt(), | |||
There was a problem hiding this comment.
I wonder if this has any (probably positive) effects on diagnostics.
|
r? @compiler-errors @bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#109170 (Set `CMAKE_SYSTEM_NAME` for Linux targets) - rust-lang#109266 (rustdoc: Correctly merge import's and its target's docs in one more case) - rust-lang#109267 (Add tests for configure.py) - rust-lang#109273 (Make `slice::is_sorted_by` implementation nicer) - rust-lang#109277 (Fix generics_of for impl's RPITIT synthesized associated type) - rust-lang#109307 (Ignore `Inlined` spans when computing caller location.) - rust-lang#109364 (Only expect a GAT const param for `type_of` of GAT const arg) - rust-lang#109365 (Update mdbook) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bjorn3
added a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105538