Remove some stale FIXMEs in new solver #109580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
Mar 25, 2023
| @@ -105,8 +103,6 @@ impl<'a, 'tcx> EvalCtxt<'a, 'tcx> { | |||
| goal: Goal<'tcx, SubtypePredicate<'tcx>>, | |||
| ) -> QueryResult<'tcx> { | |||
| if goal.predicate.a.is_ty_var() && goal.predicate.b.is_ty_var() { | |||
| // FIXME: Do we want to register a subtype relation between these vars? | |||
There was a problem hiding this comment.
this makes no sense lol
compiler-errors
commented
Mar 25, 2023
| @@ -9,8 +9,6 @@ | |||
| //! FIXME(@lcnr): Write that section. If you read this before then ask me | |||
| //! about it on zulip. | |||
| // FIXME: uses of `infcx.at` need to enable deferred projection equality once that's implemented. | |||
There was a problem hiding this comment.
We already do this :)
| @@ -78,8 +78,6 @@ impl<'tcx> SearchGraph<'tcx> { | |||
| tcx: TyCtxt<'tcx>, | |||
| goal: CanonicalGoal<'tcx>, | |||
| ) -> Result<(), QueryResult<'tcx>> { | |||
| // FIXME: start by checking the global cache | |||
There was a problem hiding this comment.
We check the global cache in the parent caller
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108625 (More config.toml.example cleanups) - rust-lang#109418 (Rename 'src/bootstrap/native.rs' to llvm.rs) - rust-lang#109580 (Remove some stale FIXMEs in new solver) - rust-lang#109582 (Refactor: Separate `LocalRef` variant for not-evaluated-yet operands) - rust-lang#109650 (Remove Nilstrieb from review rotation) - rust-lang#109656 (Update cargo) - rust-lang#109658 (Backport 1.68.1 and 1.68.2 release notes to `master`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some FIXMEs are no longer needed