Unset MIRI_BLESS for mir-opt-level 4 miri tests #111809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
|
r? miri i think this means it's not possible to bless mir-opt-level=4 tests, is that right? or is the idea that all the tests should be the same regardless of the opt level? |
|
Its the same tests, just with opts enabled to catch miscompilations. It wouldn't make sense to bless them twice. |
|
@bors r+ rollup (CI never passes --bless, which is why we never caught this in the first place) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 21, 2023
Unset MIRI_BLESS for mir-opt-level 4 miri tests When running `x.py test src/tools/miri --bless`, the 2nd test run (with mir-opt-level 4) crashes because it disables ui checking, which is incompatible with blessing. This PR fixes that by not trying to bless that run.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#111745 (Fix overflow in error emitter) - rust-lang#111770 (Read beta version from the version file if building from a source tarball) - rust-lang#111797 (Migrate GUI colors test to original CSS color format) - rust-lang#111809 (Unset MIRI_BLESS for mir-opt-level 4 miri tests) - rust-lang#111817 (Migrate GUI colors test to original CSS color format) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
x.py test src/tools/miri --bless, the 2nd test run (with mir-opt-level 4) crashes because it disables ui checking, which is incompatible with blessing. This PR fixes that by not trying to bless that run.