bootstrap: update defaults for compiler and library aliases
#112982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
cc #112440 |
abf2ad7 to
d9f4fb3
Compare
| @@ -1,6 +1,6 @@ | |||
| //! The WIP stable interface to rustc internals. | |||
| //! | |||
| //! For more information see https://github.com/rust-lang/project-stable-mir | |||
| //! For more information see <https://github.com/rust-lang/project-stable-mir> | |||
There was a problem hiding this comment.
Can you remove this change?
There was a problem hiding this comment.
This triggers the rustdoc::bare_urls lint. Because this PR builds the docs for rustc_smir now, that causes the build to fail.
There was a problem hiding this comment.
Thanks for the explanation
|
@bors rollup |
|
Thanks for the PR! |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 13, 2023
…-crates, r=albertlarsan68 bootstrap: update defaults for `compiler` and `library` aliases * `x doc compiler` now documents all of compiler, not just `rustc_driver`. * `x doc` with compiler docs enabled now includes `rustc-main` and `rustc_smir`. `rustc_codegen_llvm` is only included if the LLVM backend is enabled, which is the default. * `x doc library` now excludes `sysroot`. * `x check compiler` and `x check library` now properly check tests/benches/examples of all compiler or library crates, respectively. Note that `x check compiler` will check the library artifacts, but not tests. fixes the fallout from rust-lang#111955, cc `@jyn514`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 13, 2023
…-crates, r=albertlarsan68 bootstrap: update defaults for `compiler` and `library` aliases * `x doc compiler` now documents all of compiler, not just `rustc_driver`. * `x doc` with compiler docs enabled now includes `rustc-main` and `rustc_smir`. `rustc_codegen_llvm` is only included if the LLVM backend is enabled, which is the default. * `x doc library` now excludes `sysroot`. * `x check compiler` and `x check library` now properly check tests/benches/examples of all compiler or library crates, respectively. Note that `x check compiler` will check the library artifacts, but not tests. fixes the fallout from rust-lang#111955, cc ``@jyn514``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 13, 2023
…-crates, r=albertlarsan68 bootstrap: update defaults for `compiler` and `library` aliases * `x doc compiler` now documents all of compiler, not just `rustc_driver`. * `x doc` with compiler docs enabled now includes `rustc-main` and `rustc_smir`. `rustc_codegen_llvm` is only included if the LLVM backend is enabled, which is the default. * `x doc library` now excludes `sysroot`. * `x check compiler` and `x check library` now properly check tests/benches/examples of all compiler or library crates, respectively. Note that `x check compiler` will check the library artifacts, but not tests. fixes the fallout from rust-lang#111955, cc ```@jyn514```
|
@bors r- |
|
Yeah that rollup failure is definitely caused by this PR. It's more broken docs for |
d9f4fb3 to
1339ccf
Compare
|
certainly fix the docs |
|
☔ The latest upstream changes (presumably #113676) made this pull request unmergeable. Please resolve the merge conflicts. |
1339ccf to
9d6bfc2
Compare
|
@bors r+ rollup=maybe |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (bacf5bc): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 658.312s -> 659.454s (0.17%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x doc compilernow documents all of compiler, not justrustc_driver.x docwith compiler docs enabled now includesrustc-mainandrustc_smir.rustc_codegen_llvmis only included if the LLVM backend is enabled, which is the default.x doc librarynow excludessysroot.x check compilerandx check librarynow properly check tests/benches/examples of all compiler or library crates, respectively. Note thatx check compilerwill check the library artifacts, but not tests.fixes the fallout from #111955, cc @jyn514