Skip to content

Conversation

spastorino
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval

@rust-log-analyzer

This comment has been minimized.

@spastorino
Copy link
Member Author

Oh auto format didn't work ... force pushing ...

@spastorino spastorino changed the title Add Foreign to SMIR Add Foreign and Never tys to SMIR Jul 18, 2023
@spastorino spastorino changed the title Add Foreign and Never tys to SMIR Add Foreign, Never, FnDef and Closure tys to SMIR Jul 18, 2023
@spastorino spastorino changed the title Add Foreign, Never, FnDef and Closure tys to SMIR Add Foreign, Never, FnDef, Closure and Generator tys to SMIR Jul 18, 2023
@rust-log-analyzer

This comment has been minimized.

@spastorino
Copy link
Member Author

CI failure is unrelated

@rust-log-analyzer

This comment has been minimized.

@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2023
@spastorino spastorino added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jul 20, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 20, 2023

📌 Commit c5819b2 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2023
Add Foreign, Never, FnDef, Closure and Generator tys to SMIR

r? `@oli-obk`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#110765 (rustdoc: fix position of `default` in method rendering)
 - rust-lang#113529 (Permit pre-evaluated constants in simd_shuffle)
 - rust-lang#113800 (Avoid another gha group nesting)
 - rust-lang#113827 (Add Foreign, Never, FnDef, Closure and Generator tys to SMIR)
 - rust-lang#113835 (new solver: don't consider blanket impls multiple times)
 - rust-lang#113883 (Remove outdated Firefox-specific CSS for search's crate selector appearance)
 - rust-lang#113884 (Don't translate compiler-internal bug messages)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1a748f0 into rust-lang:master Jul 20, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants