Rollup of 6 pull requests #113949
Closed
Rollup of 6 pull requests #113949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking issue rust-lang#101719 was for `const_cstr_methods`, rust-lang#113219 is a new issue specific for `const_cstr_from_ptr`.
This extends rust-lang#109698 to allow no-cost conversion between `Vec<u8>` and `OsString` as suggested in feedback from `os_str_bytes` crate in rust-lang#111544.
Remove `#[cfg(all())]` workarounds from `c_char` Casts to type aliases are now ignored by Clippy rust-lang/rust-clippy#8596 Closes rust-lang/rust-clippy#8093
…r_lifetime, r=cuviper Remove lifetime bound for A for `impl Extend<&'a T> for Vec<T, A>`. The lifetime of the references being copied from is unrelated to the allocator. Compare with [`impl<'a, T: 'a + Copy, A: Allocator> Extend<&'a T> for VecDeque<T, A>`](https://doc.rust-lang.org/alloc/collections/vec_deque/struct.VecDeque.html#impl-Extend%3C%26'a+T%3E-for-VecDeque%3CT,+A%3E) which does not have the `A: 'a` bound already. Since `Allocator` is unstable, the only possible `A` on stable is `Global`, and `Global: 'static`, so this change is not (should not be) observable on stable (or without `#![feature(allocator_api)]`). [This is observable on nightly](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=8c4aa166c6116a90593d2934d30cfeb3).
…ing-issue, r=ChrisDenton Update the tracking issue for `const_cstr_from_ptr` Tracking issue rust-lang#101719 was for `const_cstr_methods`, rust-lang#113219 is a new issue specific for `const_cstr_from_ptr`. (I believe rust-lang#101719 could also be closed) ``@rustbot`` label +T-libs-api +A-docs
Allow limited access to `OsString` bytes This extends rust-lang#109698 to allow no-cost conversion between `Vec<u8>` and `OsString` as suggested in feedback from `os_str_bytes` crate in rust-lang#111544.
fix docs & example for `std::os::unix::prelude::FileExt::write_at` Changelog: * used `File::create` instead of `File::read` to get a writeable file * explicity mentioned the bug with `pwrite64` in docs Unfortunately, I don't think that there is really much we can do about this since the feature has already been stabilised. We could potentially add a clippy lint warning people on Linux that using `write_at` with the `O_APPEND` flag does not exhibit the behaviour that they would have assumed. fixes rust-lang#113627
…yte, r=thomcc Multibyte character removal in String::pop and String::remove doctests I think it would be useful to have the doctests for the `String::pop()` and `String::remove()` methods demonstrate that they work on multibyte UTF-8 sequences.
|
@bors r+ rollup=never p=6 |
|
⌛ Testing commit 690157d with merge c1e1fd680dd6ce3df36e26ec51fee9d12316c278... |
|
💔 Test failed - checks-actions |
|
@bors retry 2023-07-22T09:44:01.3755848Z --- stderr ------------------------------- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[cfg(all())]workarounds fromc_char#112490 (Remove#[cfg(all())]workarounds fromc_char)impl Extend<&'a T> for Vec<T, A>. #113224 (Remove lifetime bound for A forimpl Extend<&'a T> for Vec<T, A>.)const_cstr_from_ptr#113252 (Update the tracking issue forconst_cstr_from_ptr)OsStringbytes #113442 (Allow limited access toOsStringbytes)std::os::unix::prelude::FileExt::write_at#113876 (fix docs & example forstd::os::unix::prelude::FileExt::write_at)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup