Skip to content

Conversation

petrochenkov
Copy link
Contributor

Brings the docs more in line with reality

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2023
@petrochenkov
Copy link
Contributor Author

cc @nnethercote

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me modulo compatibility nit

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2023
Brings the docs more in line with reality
@petrochenkov
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Aug 16, 2023

📌 Commit 176a939 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 16, 2023
…mulacrum

proc_macro: Update docs for `Spacing`

Brings the docs more in line with reality
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 16, 2023
…mulacrum

proc_macro: Update docs for `Spacing`

Brings the docs more in line with reality
@bors
Copy link
Collaborator

bors commented Aug 16, 2023

⌛ Testing commit 176a939 with merge ce01f4d...

@bors
Copy link
Collaborator

bors commented Aug 16, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ce01f4d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2023
@bors bors merged commit ce01f4d into rust-lang:master Aug 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ce01f4d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.344s -> 635.164s (0.13%)
Artifact size: 346.74 MiB -> 346.71 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants