Skip to content

Add trait related queries to SMIR's rustc_internal #114859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2023
Merged

Add trait related queries to SMIR's rustc_internal #114859

merged 1 commit into from
Aug 16, 2023

Conversation

spastorino
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2023

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@spastorino
Copy link
Member Author

This is really low-risk ... as you've approved @compiler-errors and given that @oli-obk is on vacations, I guess I can r=compiler-errors?.

This is low risk, is going in the same direction as we go for instance in all_local_items and also ... I'd say that as soon as we have clear clients that interact with SMIR better we could do another pass with cleanups. I find the thing right now a bit untidy, but I don't clear until there's a high level of completeness. Let me know if it's ok if I bors r=you

@compiler-errors
Copy link
Member

@bors r+

@compiler-errors
Copy link
Member

github status is yellow, give it a few hours then try to re-approve if bors is still asleep

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

📌 Commit 826471e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@spastorino
Copy link
Member Author

Thanks, going to rollup as we're doing with most SMIR PRs and this one is really simple :).

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Aug 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2023
@bors
Auto merge of rust-lang#114879 - matthiaskrgr:rollup-tim571q, r=matth…
60713f4 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114721 (Optimizing the rest of bool's Ord implementation)
 - rust-lang#114746 (Don't add associated type bound for non-types)
 - rust-lang#114779 (Add check before suggest removing parens)
 - rust-lang#114859 (Add trait related queries to SMIR's rustc_internal)
 - rust-lang#114861 (fix typo: affect -> effect)
 - rust-lang#114867 ([nit] Fix a comment typo.)
 - rust-lang#114871 (Update the link in the docs of `std::intrinsics`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b54fe76 into rust-lang:master Aug 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@spastorino @rustbot @compiler-errors @bors @wesleywiser