Skip to content

Conversation

saethlin
Copy link
Member

I'm planning on landing a few PRs like this that remove ignores that aren't required. This just covers mir-opt and codegen tests.

@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2023

📌 Commit b678d40 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@bors
Copy link
Collaborator

bors commented Aug 27, 2023

⌛ Testing commit b678d40 with merge 668bf8c...

@bors
Copy link
Collaborator

bors commented Aug 27, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 668bf8c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 27, 2023
@bors bors merged commit 668bf8c into rust-lang:master Aug 27, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 27, 2023
@saethlin saethlin deleted the dont-ignore-wasm branch August 27, 2023 22:03
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (668bf8c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-2.6%, -2.2%] 2
Improvements ✅
(secondary)
-1.6% [-2.4%, -1.1%] 3
All ❌✅ (primary) -2.4% [-2.6%, -2.2%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.815s -> 631.179s (-0.10%)
Artifact size: 316.06 MiB -> 315.90 MiB (-0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants